Using Eclipse Transformer plugin to create Jakarta JAR#799
Merged
kwwall merged 1 commit intoESAPI:developfrom Nov 23, 2023
Merged
Using Eclipse Transformer plugin to create Jakarta JAR#799kwwall merged 1 commit intoESAPI:developfrom
kwwall merged 1 commit intoESAPI:developfrom
Conversation
Contributor
|
@xeno6696 and @jeremiahjstacey - I will approve this after my PR #809 gets merged. If it gets merged now, I think it likely will cause merge conflicts. |
kwwall
approved these changes
Nov 23, 2023
Contributor
kwwall
left a comment
kwwall
left a comment
There was a problem hiding this comment.
This at least seems to work up through the 'mvn compile install' step. It creates a esapi-<release>-jakarta.jar whose classes have references to the jakarta.servlet package namespace rather than the javax.servlet namespace. Whether it works when trying to upload to Maven Central, that remains to be seen, but it's worth is shot. If that part doesn't work, I'll back this change out and release 2.5.3.0 without this.
|
If this worked, it may be good to go update the README to reflect that this JAR now exists and is published to maven central? |
Contributor
|
It did work. I mentioned it in the release notes and on the Discussion
#768. But I think noting it in the README.md is also a good idea. Thanks
for the suggestion.
…-kevin
On Tue, Jan 30, 2024, 3:45 PM Jonathan Leitschuh ***@***.***> wrote:
If this worked, it may be good to go update the README to reflect that
this JAR now exists and is published to maven central?
—
Reply to this email directly, view it on GitHub
<#799 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO6PGZNGQBC5G3IUTYUPETYRFLXXAVCNFSM6AAAAAA4QTTABSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXHA3DGOBUGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Maven profile called "jakarta" that will generate a transformed JAR file, compatible with the
jakarta.servletchanges for Jakarta EE 9+I don't know how you public packages, and I doubt this is a full solution, but it at least gets you pointed in the right direction.